Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft civic file #64

Closed
wants to merge 1 commit into from
Closed

first draft civic file #64

wants to merge 1 commit into from

Conversation

tomBeach
Copy link
Contributor

First version of civic.json file

@@ -0,0 +1,50 @@

{
"id": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a URL to the schema specification per the DC gov website.

We can use

"id": "https://raw.githubusercontent.com/DCgov/civic.json/master/schemas/schema-v1.json",

from https://github.com/codefordc/civic.json/blob/master/schema.json#L3

@alulsh
Copy link
Member

alulsh commented Aug 2, 2016

Thanks for taking a stab at this @tomBeach. I added some line notes for minor things. Once those are tackled I can merge this.

@alulsh alulsh mentioned this pull request Aug 2, 2016
@alulsh
Copy link
Member

alulsh commented Aug 11, 2016

@tomBeach - any update on this? This is good work and I'd love to merge it soon! If not, I'm happy to tackle the line comments myself as well.

@alulsh
Copy link
Member

alulsh commented Aug 17, 2016

Whoops this is now saying it's from an unknown repository - I'm going to use the trick in https://speakerdeck.com/holman/more-git-and-github-secrets?slide=114 to fetch this and push as a feature branch to this repo so we can merge.

@alulsh alulsh modified the milestone: Code for DC Aug 17, 2016
@tomBeach
Copy link
Contributor Author

Sortof forgot about this PR but have now pushed a modified version of this civic.json file with the changes mentioned on new branch civicjson

@alulsh
Copy link
Member

alulsh commented Aug 22, 2016

@tomBeach - I did a compare for your new civicjson branch in https://github.com/dcfemtech/hackforgood-waba-map/compare/civicjson.

Looks like this includes the new Mapbox GL JS commits from @hrecht's WIP branch in #97.

Mind creating a new branch that doesn't have the Mapbox GL JS changes and only modifies the civic.json file? This will make your civic.json branch considerably easier to merge. We will likely need to modify @hrecht's code in her PR - it's a Work In Progress (WIP).

@alulsh
Copy link
Member

alulsh commented Sep 3, 2016

Closing in favor of #128.

@alulsh alulsh closed this Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants