-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft civic file #64
Conversation
@@ -0,0 +1,50 @@ | |||
|
|||
{ | |||
"id": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a URL to the schema specification per the DC gov website.
We can use
"id": "https://raw.githubusercontent.com/DCgov/civic.json/master/schemas/schema-v1.json",
from https://github.com/codefordc/civic.json/blob/master/schema.json#L3
Thanks for taking a stab at this @tomBeach. I added some line notes for minor things. Once those are tackled I can merge this. |
@tomBeach - any update on this? This is good work and I'd love to merge it soon! If not, I'm happy to tackle the line comments myself as well. |
Whoops this is now saying it's from an |
Sortof forgot about this PR but have now pushed a modified version of this civic.json file with the changes mentioned on new branch civicjson |
@tomBeach - I did a compare for your new Looks like this includes the new Mapbox GL JS commits from @hrecht's WIP branch in #97. Mind creating a new branch that doesn't have the Mapbox GL JS changes and only modifies the |
Closing in favor of #128. |
First version of civic.json file